Add Tests for Fixed Issues

This commit also changes the "fix" for text-only lines. We should be adjusting the text content as little as possible. In this case, we are still adding spaces (or tabs) after the last line break, but that is necessary to indent the closing element. I'll continue to adjust this as needed based on feedback and possibly add a setting to gate this behavior.

#137

src/formatting/formatters/v2-xml-formatter.ts

@@ -121,21 +121,6 @@ export class V2XmlFormatter implements XmlFormatter {
                     output += `>${options.newLine}`;
                 }
 
-                // if this is an open tag followed by a line break, add an indent before the text (after the line break)
-                // TODO: there could be multiple lines of text here, so we'll need a less naive implementation at some point
-                else if (nc === "\r" || nc === "\n") {
-                    output += `>${options.newLine}${this._getIndent(options, indentLevel)}`;
-
-                    // fast-forward based on what type of line break was used
-                    if (nc === "\r") {
-                        i += 2;
-                    }
-
-                    else {
-                        i++;
-                    }
-                }
-
                 else {
                     output += ">";
                 }

src/test/extension.test.ts

@@ -28,6 +28,18 @@ describe("V2XmlFormatter", () => {
             testFormatter(xmlFormatter, options, "basic");
         });
 
+        it("should handle unicode element names", () => {
+            testFormatter(xmlFormatter, options, "unicode");
+        });
+
+        it("should handle self-closing elements", () => {
+            testFormatter(xmlFormatter, options, "self-closing");
+        });
+
+        it("should handle text-only lines", () => {
+            testFormatter(xmlFormatter, options, "text-only-line");
+        });
+
     });
 
 });

src/test/test-data/self-closing.formatted.xml

@@ -0,0 +1,3 @@
+<Node>
+    <Node name="testChild"/>
+</Node>

src/test/test-data/self-closing.unformatted.xml

@@ -0,0 +1 @@
+<Node><Node name="testChild"/></Node>

src/test/test-data/text-only-line.formatted.xml

@@ -0,0 +1,6 @@
+<Tag>
+    <Tag2>
+Text1
+Text2
+    </Tag2>
+</Tag>

src/test/test-data/text-only-line.unformatted.xml

@@ -0,0 +1,6 @@
+<Tag>
+<Tag2>
+Text1
+Text2
+</Tag2>
+</Tag>

src/test/test-data/unicode.formatted.xml

@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Имя>
+    <element>text</element>
+</Имя>

src/test/test-data/unicode.unformatted.xml

@@ -0,0 +1,2 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Имя><element>text</element></Имя>