Authorization failure not properly detected #8

New issue

Closed

opened 2013-02-17 12:33:22 +00:00 by hanshuebner · 2 comments

hanshuebner commented

2013-02-17 12:33:22 +00:00

(Migrated from github.com)

Hi,

I'm using basex-node with BaseX 7.6 and it appears that authorization rejections are not properly detected. As far as I have determined, the server replies with '\u0001' if the login was incorrect, but the state machine in the Session constructor does not properly interpret that response and carries on as if authorization was successful. I do not quite understand the popByte function as it is, maybe it is something that you can fix easily?

Thanks (and thanks for basex-node anyway!)!
Hans

Hi, I'm using basex-node with BaseX 7.6 and it appears that authorization rejections are not properly detected. As far as I have determined, the server replies with '\u0001' if the login was incorrect, but the state machine in the Session constructor does not properly interpret that response and carries on as if authorization was successful. I do not quite understand the popByte function as it is, maybe it is something that you can fix easily? Thanks (and thanks for basex-node anyway!)! Hans

apb2006 commented

2013-02-17 17:05:33 +00:00

(Migrated from github.com)

Hi Hans,

Yes, it was a regression. Should be fixed in 0.61 now on github and npm.

Hi Hans, Yes, it was a regression. Should be fixed in 0.61 now on github and npm.

hanshuebner commented

2013-02-17 17:45:00 +00:00

(Migrated from github.com)

Works perfectly, thanks for the quick turnaround!

-Hans

On Sun, Feb 17, 2013 at 6:05 PM, Andy Bunce notifications@github.comwrote:

Hi Hans,

Yes, it was a regression. Should be fixed in 0.61 now on github and npm.

—
Reply to this email directly or view it on GitHubhttps://github.com/apb2006/basex-node/issues/8#issuecomment-13689069.

Works perfectly, thanks for the quick turnaround! -Hans On Sun, Feb 17, 2013 at 6:05 PM, Andy Bunce notifications@github.comwrote: > Hi Hans, > > Yes, it was a regression. Should be fixed in 0.61 now on github and npm. > > — > Reply to this email directly or view it on GitHubhttps://github.com/apb2006/basex-node/issues/8#issuecomment-13689069.

No labels

dependencies

javascript

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

quodatum/basex-node#8

No description provided.

Rows
Columns